Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminBundle] allow nesting non-compound forms #540

Merged
merged 1 commit into from
Jul 13, 2015

Conversation

mlebkowski
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -

For non-compound (for example a doctrine entity type) forms the obj.vars.value attribute is a scalar, so you cannot get an id from it. Use the whole value as a delete-key. I didn’t test it on the pageparts, but on the main form it works well and the delete-key isn’t used any way.

Also, the non-compound form does not have children, so the whole thing is dumped using form_widget()

@roderik roderik added this to the 3.2.1 milestone Jul 13, 2015
roderik pushed a commit that referenced this pull request Jul 13, 2015
[AdminBundle] allow nesting non-compound forms
@roderik roderik merged commit 7cb91f6 into Kunstmaan:master Jul 13, 2015
@mlebkowski mlebkowski deleted the fix/nested-forms-composite branch February 4, 2016 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants