[UtilitiesBundle] Changed Transliterator behavior to handle polish diacritics #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,8 @@ public function getSlugifyData() | |||
| array('een titel met spaties', '', 'een-titel-met-spaties'), | |||
| array('à partir d\'aujourd\'hui', null, 'a-partir-d-aujourd-hui'), | |||
| array('CaPs ShOulD be LoweRCasEd', null, 'caps-should-be-lowercased'), | |||
| array('áàäåéèëíìïóòöúùüñßæ', null, 'aaaaeeeiiiooouuunssae'), | |||
| array('áàäåéèëíìïóòöúùüñßæ', null, 'aaaaeeeiiiooouuunssae'),, | |||
There was a problem hiding this comment.
can you remote one of the ',' at the end?
There was a problem hiding this comment.
Of course... sorry for stupid mistake ... this was second pull request, because first I did in KunstmaanUtilitiesBundle... so this one I didn't test...
|
Can you have a look at the pull request guidelines? http://bundles.kunstmaan.be/documentation/contributing/pull-requests Maybe having a look to the other PR's can help you |
|
roderik
pushed a commit
that referenced
this pull request
Jun 18, 2015
changed Transliterator behavior to handle polish diacritics
roderik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed Transliterator behavior to handle polish diacritics