Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeBundle] Add button to create a duplicate of a page #392

Merged
merged 1 commit into from
May 24, 2015

Conversation

woutervandamme
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #34

I've added a button to create a duplicate of a page (at the same location in the page tree as the page being duplicated).

  • feedback

@woutervandamme woutervandamme changed the title [NodeBundle] Added button to create a duplicate of a page [NodeBundle] Add button to create a duplicate of a page May 4, 2015
@@ -147,7 +147,9 @@ public function createActionsMenu(Request $request = null)
$menu->addChild('action.addsubpage', array('linkAttributes' => array('type' => 'button', 'class' => 'btn btn-default btn--raise-on-hover', 'data-toggle' => 'modal', 'data-keyboard' => 'true', 'data-target' => '#add-subpage-modal'), 'extras' => array('renderType' => 'button')));
}
}

if (!is_null($node->getParent()) && ($this->context->isGranted(PermissionMap::PERMISSION_DELETE, $node))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PERMISSION_EDIT instead of PERMISSION_DELETE

@woutervandamme woutervandamme force-pushed the feature/duplicate_page branch from a2017cd to cc84d78 Compare May 5, 2015 11:27
@@ -21,7 +21,7 @@ class AnalyticsConfigRepository extends EntityRepository
public function findFirst($createNew = true) {
// Backwards compatibility: select the first config, still used in the dashboard, specified config ids are set in the dashboard collection bundle
$em = $this->getEntityManager();
$query = $em->createQuery( 'SELECT c FROM KunstmaanDashboardBundle:AnalyticsConfig c' );
$query = $em->createQuery( 'SELECT c FROM KunstmaanDashboardBundle:AnalyticsConfig c' )->setCacheable(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change belong to this PR?

@woutervandamme woutervandamme force-pushed the feature/duplicate_page branch from cc84d78 to 5a56941 Compare May 5, 2015 12:33
duplication of page works, need code cleanup

refactored acl security

changed permission
@woutervandamme woutervandamme force-pushed the feature/duplicate_page branch from 5a56941 to 22c038c Compare May 5, 2015 12:33
@krispypen
Copy link
Contributor

@roderik 👍

@roderik roderik added this to the 3.1.2 milestone May 24, 2015
roderik pushed a commit that referenced this pull request May 24, 2015
[NodeBundle] Add button to create a duplicate of a page
@roderik roderik merged commit 7caab8e into Kunstmaan:master May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants