-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NodeBundle] Add button to create a duplicate of a page #392
Merged
roderik
merged 1 commit into
Kunstmaan:master
from
woutervandamme:feature/duplicate_page
May 24, 2015
Merged
[NodeBundle] Add button to create a duplicate of a page #392
roderik
merged 1 commit into
Kunstmaan:master
from
woutervandamme:feature/duplicate_page
May 24, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutervandamme
changed the title
[NodeBundle] Added button to create a duplicate of a page
[NodeBundle] Add button to create a duplicate of a page
May 4, 2015
@@ -147,7 +147,9 @@ public function createActionsMenu(Request $request = null) | |||
$menu->addChild('action.addsubpage', array('linkAttributes' => array('type' => 'button', 'class' => 'btn btn-default btn--raise-on-hover', 'data-toggle' => 'modal', 'data-keyboard' => 'true', 'data-target' => '#add-subpage-modal'), 'extras' => array('renderType' => 'button'))); | |||
} | |||
} | |||
|
|||
if (!is_null($node->getParent()) && ($this->context->isGranted(PermissionMap::PERMISSION_DELETE, $node))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PERMISSION_EDIT instead of PERMISSION_DELETE
woutervandamme
force-pushed
the
feature/duplicate_page
branch
from
May 5, 2015 11:27
a2017cd
to
cc84d78
Compare
@@ -21,7 +21,7 @@ class AnalyticsConfigRepository extends EntityRepository | |||
public function findFirst($createNew = true) { | |||
// Backwards compatibility: select the first config, still used in the dashboard, specified config ids are set in the dashboard collection bundle | |||
$em = $this->getEntityManager(); | |||
$query = $em->createQuery( 'SELECT c FROM KunstmaanDashboardBundle:AnalyticsConfig c' ); | |||
$query = $em->createQuery( 'SELECT c FROM KunstmaanDashboardBundle:AnalyticsConfig c' )->setCacheable(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this change belong to this PR?
woutervandamme
force-pushed
the
feature/duplicate_page
branch
from
May 5, 2015 12:33
cc84d78
to
5a56941
Compare
duplication of page works, need code cleanup refactored acl security changed permission
woutervandamme
force-pushed
the
feature/duplicate_page
branch
from
May 5, 2015 12:33
5a56941
to
22c038c
Compare
@roderik 👍 |
roderik
pushed a commit
that referenced
this pull request
May 24, 2015
[NodeBundle] Add button to create a duplicate of a page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a button to create a duplicate of a page (at the same location in the page tree as the page being duplicated).