[AdminListBundle] Export should only export the currently selected filters #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kimausloos
commented
Apr 29, 2015
kimausloos
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #378 |
| @@ -14,10 +15,16 @@ class ExportList implements ExportableInterface | |||
| public function __construct(ExportListConfiguratorInterface $configurator) | |||
| { | |||
| $this->configurator = $configurator; | |||
| $this->configurator->buildFilters(); | |||
There was a problem hiding this comment.
The travis build is failing on this one, I think you need to add buildFilters method in the ExportListConfiguratorInterface
|
@roderik 👍 |
roderik
pushed a commit
that referenced
this pull request
Apr 29, 2015
[AdminListBundle] Export should only export the currently selected filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.