Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminBundle] Added a WYSIWYG form type #233

Merged
merged 1 commit into from
Apr 3, 2015
Merged

[AdminBundle] Added a WYSIWYG form type #233

merged 1 commit into from
Apr 3, 2015

Conversation

denbatte
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #212

TODO

  • Submit changes to the documentation

WHAT
A new wysiwyg form type has been created in the Adminbundle.
This makes it possible to use 'wysiwig' in the formbuilder as a type and results in a text area with a wysiwyg editor on top. There are two extra options you can pass as a data attribute:

  • simple: will only render a basic wysiwyg editor
  • full: will render a wysiwyg editor with extra buttons
    The wysiwyg formtype also replaces the rich text type when generating a new pagepart using the kunstmaan generatorbundle.

WHY
Before this feature there was:

        $builder->add('name', 'textarea',
                array(
                    'attr' => array(
                        'rows'  => 5,
                        'cols'  => 600,
                        'class' => 'js-rich-editor rich-editor'
                    )
                )
        );

now you just have to use:

        $builder->add('name', 'wysiwyg');

@denbatte denbatte mentioned this pull request Apr 2, 2015
@denbatte denbatte changed the title [WIP] Wysiwyg formtype added. Wysiwyg formtype added. Apr 2, 2015
@denbatte denbatte changed the title Wysiwyg formtype added. Wysiwyg formtype added Apr 2, 2015
@roderik
Copy link
Contributor

roderik commented Apr 2, 2015

@denbatte please add a changelog item? Check with @Devolicious on how

roderik pushed a commit that referenced this pull request Apr 3, 2015
@roderik roderik merged commit a7c4e96 into Kunstmaan:update-frontend-of-admin-and-demosite Apr 3, 2015
@roderik roderik changed the title Wysiwyg formtype added [AdminBundle] Added a WYSIWYG form type Apr 7, 2015
@denbatte denbatte deleted the feature/wysiwyg branch April 7, 2015 13:32
@roderik roderik modified the milestone: 3.1.0 Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants