Add build images CI job #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new GitHub workflow that builds and pushes the operators images (manager/bundle/catalog) to the kuadrant quay.io repo. Updates the Makefile to bring it inline with the rest of the kuadrant operators allowing the same GH workflow to be used in all kuadrant operator repos. Adds authorino and deploy kustomizations.
Nothing has chnaged here only the order of the resources in the manifest.
guicassolato
approved these changes
Feb 21, 2022
| run: make bundle REGISTRY=${{ env.IMG_REGISTRY_HOST }} ORG=${{ env.IMG_REGISTRY_ORG }} IMAGE_TAG=latest VERSION=0.0.0 | ||
| - name: Git diff | ||
| run: git diff | ||
| # Uncomment this when ORG in the Makefile to be updated to "kuadrant" |
There was a problem hiding this comment.
It will require some coordination to update existing references to quay.io/3scale/authorino-operator.
https://github.com/Kuadrant/authorino-operator/blob/main/.github/workflows/build-latest.yaml should also go away.
| cd $(PROJECT_DIR)/config/manager && $(KUSTOMIZE) edit set image controller=$(OPERATOR_IMAGE) ;\ | ||
| cd $(PROJECT_DIR) && $(KUSTOMIZE) build config/default >> $(DEPLOYMENT_FILE) | ||
| cd $(PROJECT_DIR) && $(KUSTOMIZE) build config/deploy > $(DEPLOYMENT_FILE) |
There was a problem hiding this comment.
A lot safer this way.
TBH, I didn't know kustomize allowed to point to remote resources. Apparently since March 2020.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new GitHub workflow that builds and pushes the operators images (manager/bundle/catalog) to the kuadrant quay.io repo.
Updates the Makefile to bring it in line with the rest of the kuadrant operators allowing the same GH workflow to be used in all kuadrant operator repos and uses kustomizations to generate authorino and deploy manifests using the upstream operand kustomization as input.
Test runs here:
Notes: