Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): enable setNextRequest for CLI #8143

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Oct 31, 2024

Background

This change basically tries to keep most of the changes from the proposed solution although some work might still be required to make the solution more comprehensive. Therefore this PR tries to make minimal changes to enable setNextRequest in CLI and also keep tests and enhancements from the proposed solution.

Changes

  • Enabled setNextRequest for CLI
  • Also included test results from pre-request tests
  • Added tests

Ref: INS-4604

@ihexxa ihexxa self-assigned this Oct 31, 2024
@ihexxa ihexxa marked this pull request as draft October 31, 2024 07:54
@ihexxa ihexxa force-pushed the feat/cli/set-next-request branch 3 times, most recently from 140905f to 73165bf Compare November 4, 2024 02:52
@ihexxa ihexxa marked this pull request as ready for review November 5, 2024 03:25
@ihexxa ihexxa requested a review from a team November 5, 2024 07:02
@ihexxa ihexxa force-pushed the feat/cli/set-next-request branch from 73165bf to d40b2f8 Compare November 5, 2024 07:03
@cwangsmv cwangsmv self-requested a review November 7, 2024 03:05
Copy link
Contributor

@cwangsmv cwangsmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test different setNextRequest situation and LGTM

@ihexxa ihexxa enabled auto-merge (squash) November 7, 2024 07:06
@ihexxa ihexxa force-pushed the feat/cli/set-next-request branch from d40b2f8 to 5f0a0bd Compare November 7, 2024 07:06
@ihexxa ihexxa merged commit 7af6fc9 into develop Nov 7, 2024
8 checks passed
@ihexxa ihexxa deleted the feat/cli/set-next-request branch November 7, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants