find: replace: Allow "replace all" in any non-binary (text) file - fixes

 #467

rn=

src/chrome/komodo/content/find/confirmrepl.js

@@ -240,14 +240,6 @@ function onTreeContextMenuShowing()
         var ignore_menuitem = document.getElementById("context_menu_ignore");
         assoc_menuitem.setAttribute("disabled", "true");
         ignore_menuitem.setAttribute("disabled", "true");
-        var selected_indeces = _get_selected_indeces();
-        if (selected_indeces.length == 1) {
-            var idx = selected_indeces[0];
-            if (_g_replacer.getSkippedReason(idx) == Components.interfaces.koIConfirmReplacerInFiles.SKIPPED_UNKNOWN_LANG) {
-                assoc_menuitem.removeAttribute("disabled");
-                ignore_menuitem.removeAttribute("disabled");
-            }
-        }
     } catch(ex) {
         log.exception(ex);
     }

src/find/findlib2.py

@@ -129,7 +129,7 @@ def find(paths, includes=None, excludes=None, env=None):
 
 def grep(regex, paths, files_with_matches=False,
          treat_binary_files_as_text=False,
-         skip_unknown_lang_paths=False,
+         skip_binary_files=False,
          skip_filesizes_larger_than=None,
          first_on_line=False,
          includes=None, excludes=None,
@@ -144,8 +144,8 @@ def grep(regex, paths, files_with_matches=False,
         Default is false.
     @param treat_binary_files_as_text {boolean} indicates that binary files
         should be search. By default they are skipped.
-    @param skip_unknown_lang_paths {boolean} can be set True to skip
-        grepping in files for which the lang could not be determined.
+    @param skip_binary_files {boolean} can be set True to skip
+        grepping in binary files.
         This is useful when doing *replacements* to be safe about not
         wrecking havoc in binary files that happen to look like plain
         text.
@@ -188,8 +188,8 @@ def grep(regex, paths, files_with_matches=False,
             yield SkipPath(path, "error determining file info: %s" % ex)
             continue
 
-        if skip_unknown_lang_paths and ti.lang is None:
-            yield SkipUnknownLangPath(path)
+        if not ti.is_text and skip_binary_files:
+            yield SkipBinaryPath(path)
             continue
         if includes:
             unmatched_includes = [field for field, value in includes
@@ -292,7 +292,7 @@ def replace(regex, repl, paths,
 
     """
     journal = None
-    grepper = grep(regex, paths, skip_unknown_lang_paths=True,
+    grepper = grep(regex, paths, skip_binary_files=True,
                    skip_filesizes_larger_than=skip_filesizes_larger_than,
                    first_on_line=first_on_line,
                    includes=includes, excludes=excludes,
@@ -587,13 +587,6 @@ class SkipBinaryPath(SkipPath):
     def __init__(self, path):
         SkipPath.__init__(self, path, "binary")
 
-class SkipUnknownLangPath(SkipPath):
-    """Event yielded when skipping a path because its lang could not be
-    identified.
-    """
-    def __init__(self, path):
-        SkipPath.__init__(self, path, "unknown language")
-
 class SkipLargeFilePath(SkipPath):
     """Event yielded when skipping a path because its filesize is too large."""
     def __init__(self, path, size):

src/find/koFinder.py

@@ -314,10 +314,7 @@ def _replace_in_paths(self, regex, repl, desc, paths):
                 continue
             elif isinstance(event, findlib2.SkipPath):
                 self.num_paths_searched += 1
-                if isinstance(event, findlib2.SkipUnknownLangPath):
-                    self.num_paths_skipped += 1
-                    self._cache_skipped_path(event)
-                elif isinstance(event, findlib2.SkipBinaryPath):
+                if isinstance(event, findlib2.SkipBinaryPath):
                     #TODO: put these as warning rows in the UI?
                     log.debug("Skip `%s' (binary).", event.path)
             elif not isinstance(event, findlib2.Hit):
@@ -604,9 +601,7 @@ def run(self):
                     continue
                 elif isinstance(event, findlib2.SkipPath):
                     self.num_paths_searched += 1
-                    if isinstance(event, findlib2.SkipUnknownLangPath):
-                        self._add_skipped_path(event)
-                    elif isinstance(event, findlib2.SkipLargeFilePath):
+                    if isinstance(event, findlib2.SkipLargeFilePath):
                         self._add_skipped_path(event)
                     elif isinstance(event, findlib2.SkipBinaryPath):
                         #TODO: put these as warning rows in the UI?
@@ -634,8 +629,6 @@ def getSkippedReason(self, row_idx):
             return components.interfaces.koIConfirmReplacerInFiles.SKIPPED_LARGE_FILE
         if isinstance(event, findlib2.SkipBinaryPath):
             return components.interfaces.koIConfirmReplacerInFiles.SKIPPED_BINARY_FILE
-        if isinstance(event, findlib2.SkipUnknownLangPath):
-            return components.interfaces.koIConfirmReplacerInFiles.SKIPPED_UNKNOWN_LANG
         return 0
 
     def toggle_mark(self, row_idx):

src/find/koIFinder.idl

@@ -76,7 +76,6 @@ interface koIConfirmReplacerInFiles : nsITreeView {
 
     const long SKIPPED_LARGE_FILE = 1;
     const long SKIPPED_BINARY_FILE = 2;
-    const long SKIPPED_UNKNOWN_LANG = 3;
 
     readonly attribute koIConfirmReplaceController controller;