Fix extension build on macOS by replacing real Virtual Reality module by a placeholder #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by a placeholder Virtual Reality is not supported on macOS. Instead of having a build error on the dashboard and extension missing from the Extensions Manager, we now create an extension that contains a stub module that just displays the message that Virtual Reality is not supported on the platform. fixes KitwareMedical#92
jcfr
reviewed
Apr 26, 2022
Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
|
@jcfr thanks for the suggestions, I've applied all of them and merged the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtual Reality is not supported on macOS. Instead of having a build error on the dashboard
and extension missing from the Extensions Manager, we now create an extension that contains
a stub module that just displays the message that Virtual Reality is not supported on the platform.
fixes #92