-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the reject_tokens_expiring_in_less_than option. #370
Add support for the reject_tokens_expiring_in_less_than option. #370
Conversation
@@ -39,6 +39,11 @@ pub struct Validation { | |||
/// | |||
/// Defaults to `60`. | |||
pub leeway: u64, | |||
/// Reject a token some time (in seconds) before the `exp` to prevent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the docs mention how it interacts with leeway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have added some explanation.
@Keats Thanks for approving; when do you think this will be merged/released? |
@Keats I do not have permissions to merge. What are the next steps for this? |
I'll merge and release in a bit when i have some free time |
Looks like there's another MSRV >_> |
@Keats Yes, looks like the build error is due to a recent change in a transitive dependency used by some tests.
While this is not strictly connected to this issue, I have gone ahead and bumped the MSRV to get things unblocked. |
@Keats any updates? Would appreciate getting this released. |
Thanks and sorry for the delay |
@Keats Thanks! |
* Add support for the reject_tokens_expiring_in_less_than option. * Add comment explaining interacting with leeway. * Update minimum supported rust version to support dependency updates.
This is a followup pull request, implementing the simplified approach discussed on #365.