Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the reject_tokens_expiring_in_less_than option. #370

Merged

Conversation

ploftness-tesla
Copy link
Contributor

This is a followup pull request, implementing the simplified approach discussed on #365.

@@ -39,6 +39,11 @@ pub struct Validation {
///
/// Defaults to `60`.
pub leeway: u64,
/// Reject a token some time (in seconds) before the `exp` to prevent
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the docs mention how it interacts with leeway?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have added some explanation.

@ploftness-tesla
Copy link
Contributor Author

@Keats Thanks for approving; when do you think this will be merged/released?

@ploftness-tesla
Copy link
Contributor Author

@Keats I do not have permissions to merge. What are the next steps for this?

@Keats
Copy link
Owner

Keats commented Feb 26, 2024

I'll merge and release in a bit when i have some free time

@Keats
Copy link
Owner

Keats commented Feb 26, 2024

Looks like there's another MSRV >_>

@ploftness-tesla
Copy link
Contributor Author

Looks like there's another MSRV >_>

@Keats Yes, looks like the build error is due to a recent change in a transitive dependency used by some tests.

% cargo tree
jsonwebtoken v9.2.0 (/Users/ploftness/Documents/jsonwebtoken)
...
[dev-dependencies]
...
├── time v0.3.31 (*)
└── wasm-bindgen-test v0.3.40
    ├── console_error_panic_hook v0.1.7
    │   ├── cfg-if v1.0.0
    │   └── wasm-bindgen v0.2.90
    │       ├── cfg-if v1.0.0
    │       └── wasm-bindgen-macro v0.2.90 (proc-macro)
    │           ├── quote v1.0.35 (*)
    │           └── wasm-bindgen-macro-support v0.2.90
...
    │               ├── wasm-bindgen-backend v0.2.90
    │               │   ├── bumpalo v3.14.0
 ...
  1. The wasm-bindgen-backend package supports bumpalo ^3.0.0
    https://crates.io/crates/wasm-bindgen-backend/0.2.90/dependencies
  2. The bumpalo package recently released some new versions that upgraded their MSRV.
    fitzgen/bumpalo@f8597ce

While this is not strictly connected to this issue, I have gone ahead and bumped the MSRV to get things unblocked.

@ploftness-tesla
Copy link
Contributor Author

@Keats any updates? Would appreciate getting this released.

@Keats Keats merged commit 29674b6 into Keats:master Mar 21, 2024
6 checks passed
@Keats
Copy link
Owner

Keats commented Mar 21, 2024

Thanks and sorry for the delay

@ploftness-tesla
Copy link
Contributor Author

@Keats Thanks!

Keats pushed a commit that referenced this pull request Aug 29, 2024
* Add support for the reject_tokens_expiring_in_less_than option.

* Add comment explaining interacting with leeway.

* Update minimum supported rust version to support dependency updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants