[OS-904] Start button not visible on small browsers #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombettany
changed the title
tombettany
approved these changes
Apr 3, 2019
views/partial/next-modal.jade
Outdated
| @@ -1,6 +1,5 @@ | |||
| .modal-overlay(ng-if='nextModal') | |||
| .modal-overlay(ng-if='nextModal').flexcenterTop | |||
There was a problem hiding this comment.
Suggested change
| .modal-overlay(ng-if='nextModal').flexcenterTop | |
| .modal-overlay.flexcenterTop(ng-if='nextModal') |
There was a problem hiding this comment.
change it in flexcenter-top
styles/elements/modal.styl
Outdated
| align-items: center | ||
| } | ||
|
|
||
| .flexcenterTop{ |
There was a problem hiding this comment.
The convention used in this project seems to be to use flexcenter-top
change class in flexcenter-top delete comments and extra space
tombettany
approved these changes
Apr 5, 2019
styles/views/splash.styl
Outdated
|
|
||
| .logo-title | ||
| illustration-fixed('layout/draw-logo') | ||
| margin 30px auto 20px | ||
| max-width: 288px | ||
| width: 100% |
styles/views/splash.styl
Outdated
| @@ -1,9 +1,12 @@ | |||
| .modal-inner.splash, .modal-inner.challenge-complete | |||
| background color-bg | |||
| width: 38% | |||
tombettany
reviewed
Apr 5, 2019
styles/elements/modal.styl
Outdated
| @@ -37,6 +51,8 @@ | |||
| width 30px | |||
| line-height @width | |||
|
|
|||
| width | |||
There was a problem hiding this comment.
By the way, what does this width without a parameter do?
tombettany
changed the title
|
feat: start button visible on browser all the time, add responsive design, delete style issues |
paulvarache
pushed a commit
that referenced
this pull request
May 6, 2019
This commit add responsive design to most of the popups in make art using flex-box. Before when we used to open make art through any browser the start button to access any challenge overflowed, preventing to be clicked. In order to allow users always to click the start button I applied responsive design with flex-box. I also went through some styling fix, deleting the unnecessary colon and semicolon in styl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix responsive popouts