-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapted from Argentina to all Spanish countries #423
Open
carlogarro
wants to merge
693
commits into
KanoComputing:master
Choose a base branch
from
carlogarro:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not show fullscreen option in challenges.
* When integrating kano-draw from QML, the launcher process would morph, and the UI frontend keep running * Fixed by not killing the parent from the http process * Forcibly killing the UI process from the launcher more agressively (SIGKILL)
KanoComputing/os-dashboard#90 An error message appears when attempting to close the app in offline mode. This is because the server, instead of responding, just shuts down and hence doesn't reply. This means that the application itself doesn't get a response so assumes that something is wrong. Resolve this by replying and not displaying a success message when this happens.
GTM tag, remove segment.io
* note: detailed syntax error messages removed in es_AR!
translated “you’ve earned {int} XP”
i18n error messages
* Speed up load times * Rectified function comment
Fixes were made to the English step validation for Pixel Hack challenges to allow them to properly progress. Apply these fixes to the es_AR version of the app.
The instructions tell the user, in Spanish, to type the literal "elipse". Given that the users are unlikely to know the English word, asking them to fix a spelling mistake is quite a task. Spell this correctly.
Bump version for 3.9.2 release.
Bump version for 3.11.0 release.
* Replaced splash window for animation * Using animation keyword
If the user launches a share from one of the challenge pack pages on Kano OS and then clicks the "Back" button they were presented with a 404 page because Angular handles the page redirection instead of the server. Resolve this by returning the homepage (main Angular app) from the server when all routes of the form `/challenge/.*` are requested.
Manually install Node 6 when building the Debian package.
Resolve conflicts with bower install to permit non-interactive build.
Bower: Resolve bower install conflicts
The purpose here is to avoid running profiling code in production. This should perhaps only be enabled in a special env.
Fixing the build
…cally Spanish in all Spanish countries and not only in Argentina.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The es-AR concept was only working automatically in browsers with the Argentinian Spanish predefined, which is not by default in Spanish, Mexican, Peruvian, Cuban, etc. computers.
So, I have decided to change it for es, and now all Spanish countries will be able to see it in Spanish.