Fix leaky promisses

KanoComputing · Nov 29, 2017 · c771413 · c771413
1 parent ba8351d
commit c771413
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/lib/deploy-methods/s3.js b/lib/deploy-methods/s3.js
@@ -100,16 +100,13 @@ function _doReleaseBySync(build, target, data) {
 
                         cleanupCb();
                         resolve();
-                        console.log('SYNCED!', stdout, stderr);
                     });
                 });
             } catch (error) {
                 cleanupCb();
                 throw error;
             }
         });
-
-        resolve();
     });
 }
 
@@ -225,7 +222,7 @@ function release(build, opts) {
             return _doRelease(build, bucket, algorithm);
         }).then((r) => {
             releaseObject = r;
-            _uploadKartFile(releaseObject, bucket);
+            return _uploadKartFile(releaseObject, bucket);
         }).then(() => {
             return Promise.resolve(releaseObject);
         });