Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env.render(mode="human") #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johan-gras
Copy link

Problem description:
env.render() or env.render(mode="human"), wasnt't working anymore after this change in #43

This change was IMO an error and should be reverted, this is the purpose of this commit.
Should resolve #92

Human rendering was not working anymore since Kaggle#43
@johan-gras
Copy link
Author

Please can you take a look @harrisse to this really small PR. Thanks.

@harrisse
Copy link
Contributor

Apologies for the delay and thanks for the ping. This line should print the human-readable result when there is not an output path: https://github.com/Kaggle/kaggle-environments/blob/master/kaggle_environments/main.py#L345

Can you confirm the command you're using to run kaggle-environments so I can reproduce on my end?

@harrisse harrisse self-requested a review February 25, 2021 22:12
Copy link
Contributor

@harrisse harrisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to requesting changes pending further discussion.

@johan-gras
Copy link
Author

Can you confirm the command you're using to run kaggle-environments so I can reproduce on my end?

from kaggle_environments import make, evaluate, utils
env=make("connectx", debug=True)
env.render(mode="human")

Expected behavior: print the env
Current behavior: doesn't do anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment.render() does nothing with default arguments
2 participants