Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove probes #82

Merged
merged 5 commits into from
Sep 4, 2023
Merged

remove probes #82

merged 5 commits into from
Sep 4, 2023

Conversation

keiyamamo
Copy link
Collaborator

We will use different method for probe based on

################################################################################
# the function mpi4py_comm and peval are used to overcome FEniCS limitation of
# evaluating functions at a given mesh point in parallel.
# https://fenicsproject.discourse.group/t/problem-with-evaluation-at-a-point-in
# -parallel/1188
def mpi4py_comm(comm):
'''Get mpi4py communicator'''
try:
return comm.tompi4py()
except AttributeError:
return comm
def peval(f, x):
'''Parallel synced eval'''
try:
yloc = f(x)
except RuntimeError:
yloc = np.inf*np.ones(f.value_shape())
comm = mpi4py_comm(f.function_space().mesh().mpi_comm())
yglob = np.zeros_like(yloc)
comm.Allreduce(yloc, yglob, op=pyMPI.MIN)
return yglob
################################################################################

Thus, removing all the prove related files.

Copy link
Collaborator

@johannesring johannesring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we can remove this. Please also remove cppimport from environment.yml and setup.py, and package_data from setup.py.

BTW, Womersley.py can also be removed.

@keiyamamo
Copy link
Collaborator Author

Hi @johannesring I made some modifications based on your feedback. If it looks fine, I will merge :)

@keiyamamo keiyamamo merged commit a209f92 into KVSlab:master Sep 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants