Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert config #77

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Revert config #77

merged 2 commits into from
Jul 5, 2023

Conversation

keiyamamo
Copy link
Collaborator

Ref #75

@johannesring
Copy link
Collaborator

@keiyamamo - Is pyaml no longer needed now? Can it be removed?

@keiyamamo
Copy link
Collaborator Author

@johannesring I tested deleting pyaml and it is still necessary.

@keiyamamo
Copy link
Collaborator Author

@johannesring
I tried to remove pyaml but then I got the following error from domain.py.

 File "/Users/keiyamamoto/Documents/turtleFSI/turtleFSI/modules/domain.py", line 103, in assign_domain_properties
    assert isinstance(solid_properties, list), "solid_properties must be a list of dictionaries"
AssertionError: solid_properties must be a list of dictionaries

Even though solid_properties was passed correctly as parameter, it is str and not list or dictionary. I would say keeping pyaml is the easiest for now. If this seems fine, I will merge the PR.

@keiyamamo keiyamamo requested a review from johannesring July 5, 2023 07:23
Copy link
Collaborator

@johannesring johannesring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@keiyamamo keiyamamo merged commit 34925be into KVSlab:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants