Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make k_s and c_s type check more general by allowing any iterable #111

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

johannesring
Copy link
Collaborator

This PR updates the type checking for k_s and c_s in the solid_setup function to allow any iterable type (e.g., lists, tuples) instead of strictly requiring lists.

@keiyamamo
Copy link
Collaborator

Hi @johannesring Thank you for the PR. Looks good to me. Do you know why there is no test running for this PR?

@johannesring
Copy link
Collaborator Author

No, I don't know.

@keiyamamo
Copy link
Collaborator

https://github.com/orgs/community/discussions/65321

Maybe this could help?

@johannesring johannesring merged commit 5fa4138 into master Nov 26, 2024
9 checks passed
@johannesring johannesring deleted the johannr/flexible-ks-cs-types branch November 26, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants