Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to using Dates.jl instead of Calendar.jl #9

Closed
wants to merge 1 commit into from

Conversation

WestleyArgentum
Copy link
Collaborator

I haven't done all the testing in the world, but so far this works pretty well.

It also happens to fix the ambiguity warnings we get when using HttpCommon and DataArrays at the same time, see JuliaStats/DataArrays.jl#115, #6, etc

Would love feedback!

@jiahao
Copy link

jiahao commented Aug 23, 2014

cc @quinnj

@quinnj
Copy link
Member

quinnj commented Aug 25, 2014

Ok @WestleyArgentum, we can actually do better! I actually had some work on parsing/formatting for days of the week, and so I cleaned up that code and pushed the changes. You can now do

julia> using Dates

julia> Dates.format(DateTime(2014),Dates.RFC1123Format)
"Wed, 01 Jan 2014 00:00:00"

So I believe this removes the need for ICU as well. Care to update the PR?

@WestleyArgentum
Copy link
Collaborator Author

That's awesome! Did you write that without introducing a dependence on ICU?

I'll look at the code and update this!

@WestleyArgentum
Copy link
Collaborator Author

Oh, missed your mention of ICU haha, nice!

@quinnj
Copy link
Member

quinnj commented Aug 25, 2014

Yeah, nowutc() is now defined in Dates.jl as well, so no need to define it here.

@WestleyArgentum WestleyArgentum mentioned this pull request Aug 25, 2014
@WestleyArgentum
Copy link
Collaborator Author

Oh! Didn't see that change - will include it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants