Use pdftocairo from Poppler_jll instead of pdf2svg #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! |
|
This is good with me. @tawheeler are you okay with the merge? |
|
An all-Julia implementation is definitely better. Assuming it works on Windows and Linux, we're good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poppler_jll.jl provides
pdftocairobinary which could be a replacement forpdf2svg.A good is that users no longer need to have external
pdf2svginstalled manually. A caveat though is that jll requires Julia 1.3+.Only tested on macOS for now. I believe it should work on Windows and Linux too.