Switch to Graphs.jl instead of LightGraphs.jl #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rejuvyesh
reviewed
Nov 12, 2021
| @@ -3,13 +3,13 @@ uuid = "b4f28e30-c73f-5eaf-a395-8a9db949a742" | |||
| version = "1.2.0" | |||
There was a problem hiding this comment.
Will make sense to move the version to "1.3.0"?
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 1 1
Lines 54 54
=======================================
Hits 45 45
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rejuvyesh
reviewed
Nov 14, 2021
| @@ -3,13 +3,13 @@ uuid = "b4f28e30-c73f-5eaf-a395-8a9db949a742" | |||
| version = "1.2.0" | |||
There was a problem hiding this comment.
Suggested change
| version = "1.2.0" | |
| version = "1.3.0" |
|
Could we generate the figures in the ipynb? That way readers can see the output. |
|
I updated the ipynb in #47. Sorry, I don't think I had permission to push to your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45