Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CSV version 0.10. Fix double quote escapes in datasets.csv #132

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

andreasnoack
Copy link
Member

It's been parsed incorrectly in previous versions of CSV because the default escape character is " while the file was using \.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022

Codecov Report

Merging #132 (2b13080) into master (3816963) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files           3        3           
  Lines          18       24    +6     
=======================================
+ Hits           15       20    +5     
- Misses          3        4    +1     
Impacted Files Coverage Δ
src/packages.jl 100.00% <0.00%> (ø)
src/dataset.jl 90.90% <0.00%> (+0.90%) ⬆️
src/datasets.jl 62.50% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3816963...2b13080. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants