Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in kde_range #39

Closed
OmriTreidel opened this issue Sep 30, 2016 · 0 comments · Fixed by #52
Closed

bug in kde_range #39

OmriTreidel opened this issue Sep 30, 2016 · 0 comments · Fixed by #52

Comments

@OmriTreidel
Copy link

There seem to be a problem with kde_range in univariant.jl: The range that is returned sometimes has the wrong number of points.

Can be easily detected by inserting length(lo:step:hi) == npoints || @show "ERROR", length(lo:step:hi)
before returning.

I think it results from a problem is linspace.

Suggested fix:

return lo + (0:npoints-1)*step instead of lo:step:hi
@OmriTreidel OmriTreidel mentioned this issue Sep 30, 2016
Open
tlnagy added a commit to tlnagy/KernelDensity.jl that referenced this issue Jun 3, 2018
@tlnagy
use improved high numerical precision linspace from Base
8a6b97c 
KernelDensity.jl rolled its own range generator which suffers from
similar flaws as Base's linspace prior to being fixed in
JuliaLang/julia#18777. This closes JuliaStats#39.
@tlnagy tlnagy mentioned this issue Jun 3, 2018
Merged
tlnagy added a commit to tlnagy/KernelDensity.jl that referenced this issue Jun 10, 2018
@tlnagy
use improved high numerical precision range from Base
c1d43db 
KernelDensity.jl rolled its own range generator which suffers from
similar flaws as Base's linspace prior to being fixed in
JuliaLang/julia#18777. This closes JuliaStats#39.
ararslan pushed a commit that referenced this issue Jun 10, 2018
@tlnagy @ararslan
use improved high numerical precision range from Base (#52)
a0a0859 
KernelDensity.jl rolled its own range generator which suffers from
similar flaws as Base's linspace prior to being fixed in
JuliaLang/julia#18777. This closes #39.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use improved high numerical precision linspace from Base tlnagy/KernelDensity.jl
1 participant
@OmriTreidel