Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single precision in core_interface.jl #366

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

amontoison
Copy link
Member

No description provided.

@amontoison amontoison requested a review from tmigot August 20, 2024 02:43
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 88.20225% with 21 lines in your changes missing coverage. Please review.

Project coverage is 61.40%. Comparing base (f2ad6a4) to head (f11dc1b).
Report is 44 commits behind head on main.

Files Patch % Lines
src/model.jl 79.72% 15 Missing ⚠️
src/sifdecoder.jl 60.00% 4 Missing ⚠️
src/julia_interface.jl 97.22% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #366       +/-   ##
===========================================
- Coverage   89.11%   61.40%   -27.71%     
===========================================
  Files           5        8        +3     
  Lines         790     1433      +643     
===========================================
+ Hits          704      880      +176     
- Misses         86      553      +467     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it will be easier to debug the single precision with the unit tests to follow.

@amontoison
Copy link
Member Author

Looks good to me, it will be easier to debug the single precision with the unit tests to follow.

We need a new version of CUTEst_jll.jl to use single and quadruple precision.
The issue is that I have an error in the garbage collector so I only allow double precision for now.
I suspect that the error is upstream.

@amontoison amontoison merged commit 8295d72 into JuliaSmoothOptimizers:main Aug 21, 2024
7 of 15 checks passed
@amontoison amontoison deleted the generic_cutest branch August 21, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants