Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a standalone sifdecoder function #339

Merged
merged 6 commits into from
Aug 17, 2024

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Aug 16, 2024

close #335

  • Add a new file sifdecoder.jl
  • Split the previous function sifdecoder into two new functions sifdecoder and build_libsif
  • Add CI on Windows
  • Test the new function sifdecoder on all platforms
  • Add an option libsif_folder to specify where we want to decode the SIF problems and build the shared libraries

@amontoison
Copy link
Member Author

@jfowkes The binary sifdecoder_standalone is working on Windows!
It could be relevant for PyCUTEst.
https://github.com/JuliaSmoothOptimizers/CUTEst.jl/actions/runs/10426477345/job/28879483562?pr=339#step:7:151

@amontoison amontoison requested a review from tmigot August 16, 2024 21:37
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great ! Thanks @amontoison

@amontoison amontoison merged commit 89e5066 into JuliaSmoothOptimizers:main Aug 17, 2024
10 of 13 checks passed
@amontoison amontoison deleted the sifdecoder branch August 17, 2024 00:33
amontoison added a commit to amontoison/CUTEst.jl that referenced this pull request Aug 17, 2024
* Add a standalone sifdecoder function

* Add a standalone sifdecoder function

* Fix a typo

* Use verbose mode for the sifdecoder

* Update the tests for the sifdecoder

* add an option to specify where we want to decode the SIF problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the function sifdecoder
2 participants