Generate Julia wrappers with Clang.jl #332
Conversation
amontoison
commented
Aug 14, 2024
•
amontoison
commented
- Generate Julia wrappers for single and double precision of CUTEst
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
===========================================
- Coverage 89.11% 61.66% -27.46%
===========================================
Files 5 6 +1
Lines 790 1132 +342
===========================================
- Hits 704 698 -6
- Misses 86 434 +348 ☔ View full report in Codecov by Sentry. |
| @@ -215,8 +218,8 @@ function sifdecoder( | |||
| end | |||
| run(`mv OUTSDIF.d $outsdif`) | |||
| delete_temp_files(suffix) | |||
| global cutest_lib = | |||
| Libdl.dlopen(libname, Libdl.RTLD_NOW | Libdl.RTLD_DEEPBIND | Libdl.RTLD_GLOBAL) | |||
| global cutest_lib = Libdl.dlopen(libname, Libdl.RTLD_NOW | Libdl.RTLD_DEEPBIND | Libdl.RTLD_GLOBAL) | |||
There was a problem hiding this comment.
This will be modified again by the formatter, no?
There was a problem hiding this comment.
Yes, but I modified the name of the variable before that I reverted it.
There was a problem hiding this comment.
The auto formater will probably fix other things.
| @@ -0,0 +1,1008 @@ | |||
| function CUTEst_malloc(object, length, s) | |||
There was a problem hiding this comment.
The follow-up PR is to use this interface in the code, right? I guess most of https://github.com/JuliaSmoothOptimizers/CUTEst.jl/blob/main/src/core_interface.jl will be updated then, and you can reuse the docstrings
There was a problem hiding this comment.
Yes, that's the plan.
I already did the modification on my laptop.
It will open a PR for you.
It should be easy to implement CUTEstModel in single and quadruple precision now.
Co-authored-by: Tangi Migot <[email protected]>
amontoison
merged commit fff8ac8
into
JuliaSmoothOptimizers:main
|
Thanks for the review @tmigot! |
