Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to citation file #328

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Update link to citation file #328

merged 3 commits into from
Aug 14, 2024

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented May 30, 2024

No description provided.

@tmigot
Copy link
Member Author

tmigot commented May 30, 2024

@dpo a PR that better isolate the issue on macOS

@tmigot tmigot mentioned this pull request May 30, 2024
@dpo
Copy link
Member

dpo commented May 30, 2024

@tmigot This is a different error. Here the issue is that you're building on Mac x64, but CUTEst_jll.jl installs the aarch64 shared libraries (probably because of the gfortran version). I noticed the same in my recent SolverBenchmark PR and updated to workflow: see lines 18-26 of https://github.com/JuliaSmoothOptimizers/SolverBenchmark.jl/blob/main/.github/workflows/examples.yml#L18

@tmigot tmigot closed this Aug 9, 2024
@tmigot tmigot reopened this Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (f2ad6a4) to head (60bc164).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   89.11%   88.21%   -0.91%     
==========================================
  Files           5        5              
  Lines         790      789       -1     
==========================================
- Hits          704      696       -8     
- Misses         86       93       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontoison
Copy link
Member

You need macos-13 if you want to the architecture x64, macos-latest is macos-14 and only available on recent Mac with the architecture arm64.

@amontoison amontoison merged commit 1e8bcc8 into main Aug 14, 2024
13 of 20 checks passed
@amontoison amontoison deleted the fix-readme-link-cff branch August 14, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants