Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CUTEst_jll 2.0.6 #300

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Conversation

amontoison
Copy link
Member

No description provided.

@lrsantos11
Copy link

lrsantos11 commented Feb 10, 2023

Guys, without CUTEst_jll 2.0.5 one cannot use CUTEst.jl on arm Macs. Any update on this?

@dpo dpo closed this Feb 12, 2023
@dpo dpo reopened this Feb 12, 2023
@amontoison
Copy link
Member Author

@dpo I propose to recompile the version "2.0.4" of CUTEST_jll. The last modifications in CUTEST break things here.
We just need to use the version number "2.0.6" for the Artifact.

@amontoison
Copy link
Member Author

Guys, without CUTEst_jll 2.0.5 one cannot use CUTEst.jl on arm Macs. Any update on this?

@lrsantos11
I just recompiled CUTEst with Yggdrasil (JuliaPackaging/Yggdrasil#6461).
I will update this PR asap.

@amontoison amontoison self-assigned this Mar 27, 2023
@amontoison amontoison changed the title Use CUTEst_jll 2.0.5 Use CUTEst_jll 2.0.6 Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a35e8f5) 88.60% compared to head (f5cf8c0) 88.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   88.60%   88.60%           
=======================================
  Files           5        5           
  Lines         790      790           
=======================================
  Hits          700      700           
  Misses         90       90           
Impacted Files Coverage Δ
src/CUTEst.jl 85.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amontoison
Copy link
Member Author

amontoison commented Mar 27, 2023

Great, it works on the new Macs! 🎉

@amontoison amontoison merged commit 0092d43 into JuliaSmoothOptimizers:main Mar 27, 2023
@amontoison amontoison deleted the support-M1 branch March 27, 2023 21:40
@dpo
Copy link
Member

dpo commented Mar 28, 2023

Excellent! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants