Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lencheck everywhere #294

Merged
merged 1 commit into from
Aug 11, 2022
Merged

add lencheck everywhere #294

merged 1 commit into from
Aug 11, 2022

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Aug 11, 2022

This allows to replace things like hv[1:(nlp.meta.nvar)] .= hvc by hv .= hvc

@tmigot tmigot linked an issue Aug 11, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #294 (44f9245) into main (618f6fc) will increase coverage by 1.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   87.04%   88.31%   +1.26%     
==========================================
  Files           5        5              
  Lines         710      787      +77     
==========================================
+ Hits          618      695      +77     
  Misses         92       92              
Impacted Files Coverage Δ
src/julia_interface.jl 99.76% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dpo
Copy link
Member

dpo commented Aug 11, 2022

I agree. The user can always pass in views.

@tmigot tmigot merged commit 39298ac into main Aug 11, 2022
@tmigot tmigot deleted the add-lencheck branch August 11, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check input sizes
2 participants