Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linear API #284

Merged
merged 6 commits into from
Aug 8, 2022
Merged

Add linear API #284

merged 6 commits into from
Aug 8, 2022

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Jul 11, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #284 (e89575d) into main (c9e937c) will increase coverage by 2.57%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   84.61%   87.18%   +2.57%     
==========================================
  Files           5        5              
  Lines         598      718     +120     
==========================================
+ Hits          506      626     +120     
  Misses         92       92              
Impacted Files Coverage Δ
src/CUTEst.jl 84.44% <100.00%> (+1.11%) ⬆️
src/julia_interface.jl 99.71% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464d610...e89575d. Read the comment docs.

@tmigot tmigot requested a review from dpo July 12, 2022 08:21
src/julia_interface.jl Outdated Show resolved Hide resolved
src/julia_interface.jl Outdated Show resolved Hide resolved
src/julia_interface.jl Outdated Show resolved Hide resolved
src/julia_interface.jl Outdated Show resolved Hide resolved
@tmigot tmigot marked this pull request as draft July 25, 2022 14:46
@tmigot
Copy link
Member Author

tmigot commented Jul 26, 2022

This is ready for another review. Thanks for the comments, I think I fixed most of them and tried to improve.

@tmigot tmigot marked this pull request as ready for review July 26, 2022 20:07
@tmigot tmigot requested a review from dpo July 26, 2022 20:07
Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you! The worry is that all those loops are slow, but currently, there's no other way.

src/julia_interface.jl Show resolved Hide resolved
src/julia_interface.jl Show resolved Hide resolved
@tmigot tmigot merged commit ebb3ab2 into main Aug 8, 2022
@tmigot tmigot deleted the add-linear-API branch August 8, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants