Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests for problem hs14 #281

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Fix unit tests for problem hs14 #281

merged 1 commit into from
Jul 10, 2022

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Jul 10, 2022

Since https://github.com/JuliaSmoothOptimizers/NLPModelsTest.jl/pull/50/files there nonlinear function in NLPModelsTest.jl and CUTEst.jl now differs. So, I suggest to test with the function (defined in this PR) compare_cons.

The unit tests then break because of the linear API, see https://github.com/JuliaSmoothOptimizers/CUTEst.jl/tree/add-linear-API (with NLPModelsTest 0.8.1), coming in a following PR

@tmigot tmigot requested a review from abelsiqueira July 10, 2022 20:53
@abelsiqueira abelsiqueira reopened this Jul 10, 2022
@abelsiqueira
Copy link
Member

Thanks for the PR

@abelsiqueira abelsiqueira merged commit 3abfc9c into main Jul 10, 2022
@abelsiqueira abelsiqueira deleted the fix-hs14 branch July 10, 2022 23:09
@tmigot tmigot linked an issue Aug 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test fails for HS14
2 participants