Add support for view inputs #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 5 5
Lines 598 598
=======================================
Hits 506 506
Misses 92 92
Continue to review full report at Codecov.
|
dpo
requested changes
Aug 30, 2021
Co-authored-by: Dominique <[email protected]>
Co-authored-by: Dominique <[email protected]>
Co-authored-by: Dominique <[email protected]>
abelsiqueira
approved these changes
Sep 1, 2021
|
thank you! |
|
thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey JSO devs, we've been using CUTEst.jl for benchmarking our solver MadNLP.jl, and we recently found that JSO's current julia interface does not efficiently handle view inputs. Please consider merging this PR.
This PR adds better support for view inputs for CUTEst.jl's julia interface.
The current CUTEst.jl julia interface converts any
AbstractVectorinput toVector{Float64}to make it compatible with subsequent ccalls, and this process accompanies memory allocations. But when the AbstractVector is a stride-one array (which typically comes from a view of aVectorover aUnitRange), this can be avoided by directly passing it to C functions.I have added the definition for
StrideOneVector{T}, and replaced the type specifications in the functions from::Vector{Float64}to::StrideOneVector{Float64}. This change allows directly using stride-one vectors as inputs to the C functions instead of allocating more memory. I have also added a test forStrideOneVector{T}intest_core.jl.