Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NLPModels 0.15 #260

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Update to NLPModels 0.15 #260

merged 2 commits into from
Jun 16, 2021

Conversation

abelsiqueira
Copy link
Member

CUTEst only works with Float64, so the struct is specialized.
I don't know if it works with GPU. If it does, I can change to S.

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #260 (6dea5f5) into master (9ce3961) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   84.62%   84.62%           
=======================================
  Files           5        5           
  Lines         592      592           
=======================================
  Hits          501      501           
  Misses         91       91           
Impacted Files Coverage Δ
src/CUTEst.jl 83.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce3961...6dea5f5. Read the comment docs.

@abelsiqueira abelsiqueira requested a review from dpo June 12, 2021 20:26
Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@dpo
Copy link
Member

dpo commented Jun 13, 2021

PS: I don’t think anything here will work on gpu. We’ll have to convert vectors back and forth all the time.

@abelsiqueira abelsiqueira merged commit e37ad4a into master Jun 16, 2021
@abelsiqueira abelsiqueira deleted the nlpmodels-0.15 branch June 16, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants