Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: MLJFlow v0.5.0 #107366

Merged
merged 1 commit into from
May 21, 2024

Conversation

JuliaRegistrator
Copy link
Contributor

- **[breaking]** Renaming `_logging_channel` to `logging_channel`, and changing its type from `Channel{Tuple}` to `Union{Channel{Tuple}, Nothing}`
- **[breaking]** `open_logging_channel` function now requires a `Logger` instance and doesn't return a `Channel` anymore. The reason is to keep `logging_channel` in a "private" form in our model
- **[improvement]** Removed non-useful `wait!(result_channel)` in `src/base.jl`
- **[improvement]** Explicitly closing the `logging_channel` when a result is retrieved in the background worker

UUID: 7b7b8358-b45c-48ea-a8ef-7ca328ad328f
Repo: https://github.com/JuliaAI/MLJFlow.jl.git
Tree: 508bff8071d7d1902d6f1b9d1e868d58821f1cfe

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit b3af430 into master May 21, 2024
22 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-mljflow-7b7b8358-v0.5.0-70e6786255 branch May 21, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants