-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some deprecation warnings #465
Fix some deprecation warnings #465
Conversation
Sorry, we cannot merge more PRs regarding teh/constrained before #303 is completed. (just kiddinng ofc, though I actually started the process of bringing that up to date just yesterday!) |
Are you ok with the v0.5 failures? Then maybe you should update the travis file. Not that anyone but you and your lab would really care, but... Then you get to see the green check mark! |
Codecov Report
@@ Coverage Diff @@
## teh/constrained #465 +/- ##
===================================================
- Coverage 72.41% 71.75% -0.66%
===================================================
Files 32 32
Lines 2070 2075 +5
===================================================
- Hits 1499 1489 -10
- Misses 571 586 +15
Continue to review full report at Codecov.
|
That's great to hear! Do keep in mind that because #303 won't actually be useful to my lab (at least, not for our "main" need) and I already maintain far too many other packages, it's pretty much up to others to keep it working and fix bugs. If you have questions about how it works I can hopefully help answer them. |
Do you want me to merge it? |
Yes please. (I don't have permission.) |
Must have happened in the org move. I’ll have a look at it later |
Note this is against teh/constrained