Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some deprecation warnings #465

Merged
merged 2 commits into from
Sep 24, 2017
Merged

Fix some deprecation warnings #465

merged 2 commits into from
Sep 24, 2017

Conversation

timholy
Copy link
Contributor

@timholy timholy commented Sep 19, 2017

Note this is against teh/constrained

@pkofod
Copy link
Member

pkofod commented Sep 19, 2017

Sorry, we cannot merge more PRs regarding teh/constrained before #303 is completed.

(just kiddinng ofc, though I actually started the process of bringing that up to date just yesterday!)

@pkofod
Copy link
Member

pkofod commented Sep 20, 2017

Are you ok with the v0.5 failures? Then maybe you should update the travis file. Not that anyone but you and your lab would really care, but... Then you get to see the green check mark!

@codecov
Copy link

codecov bot commented Sep 23, 2017

Codecov Report

Merging #465 into teh/constrained will decrease coverage by 0.65%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           teh/constrained     #465      +/-   ##
===================================================
- Coverage            72.41%   71.75%   -0.66%     
===================================================
  Files                   32       32              
  Lines                 2070     2075       +5     
===================================================
- Hits                  1499     1489      -10     
- Misses                 571      586      +15
Impacted Files Coverage Δ
src/constraints.jl 65.15% <ø> (ø) ⬆️
src/problems/constrained.jl 75% <100%> (ø) ⬆️
src/problems/unconstrained.jl 32.18% <100%> (ø) ⬆️
src/types.jl 37.63% <50%> (ø) ⬆️
src/interior.jl 48.74% <66.66%> (+0.68%) ⬆️
src/momentum_gradient_descent.jl 83.72% <0%> (-4.38%) ⬇️
src/golden_section.jl 82.97% <0%> (-3.98%) ⬇️
src/brent.jl 90% <0%> (-2.41%) ⬇️
src/simulated_annealing.jl 92.85% <0%> (-2.27%) ⬇️
src/gradient_descent.jl 93.02% <0%> (-2.22%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61a8d1...f308ed0. Read the comment docs.

@timholy
Copy link
Contributor Author

timholy commented Sep 23, 2017

(just kiddinng ofc, though I actually started the process of bringing that up to date just yesterday!)

That's great to hear! Do keep in mind that because #303 won't actually be useful to my lab (at least, not for our "main" need) and I already maintain far too many other packages, it's pretty much up to others to keep it working and fix bugs. If you have questions about how it works I can hopefully help answer them.

@pkofod
Copy link
Member

pkofod commented Sep 23, 2017

Do you want me to merge it?

@timholy
Copy link
Contributor Author

timholy commented Sep 23, 2017

Yes please. (I don't have permission.)

@pkofod pkofod merged commit 09c896c into JuliaNLSolvers:teh/constrained Sep 24, 2017
@pkofod
Copy link
Member

pkofod commented Sep 24, 2017

Must have happened in the org move. I’ll have a look at it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants