Generalize box constrained optimization slightly. #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
Trying to clean up the issues, I stumbled upon #89 . This PR fixes the "keyword" issues where "eta" and the preconditioner-keywords were forced into the optimizer constructors. This enables
which will be preconditioned due to the recent refactoring + improvement of preconditioning, but also
or even
You might not want to do it, but currently, all the methods in Optim should be passable, although Newton will generate a warning and default to CG.