Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halve step in MoreThuente if initial step generates nonfinite values #73

Merged
merged 3 commits into from
Nov 22, 2017

Conversation

anriseth
Copy link
Collaborator

@anriseth anriseth commented Nov 17, 2017

Also adds some @inbounds steps to BackTracking

@codecov
Copy link

codecov bot commented Nov 17, 2017

Codecov Report

Merging #73 into master will decrease coverage by 0.22%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage    62.5%   62.27%   -0.23%     
==========================================
  Files           8        8              
  Lines         600      607       +7     
==========================================
+ Hits          375      378       +3     
- Misses        225      229       +4
Impacted Files Coverage Δ
src/backtracking.jl 81.81% <100%> (ø) ⬆️
src/morethuente.jl 54.39% <66.66%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56155bd...6eb382c. Read the comment docs.

@pkofod
Copy link
Member

pkofod commented Nov 18, 2017

Is this from from the original ?

@anriseth
Copy link
Collaborator Author

anriseth commented Nov 19, 2017 via email

@anriseth anriseth merged commit 5cd79f4 into master Nov 22, 2017
@anriseth anriseth deleted the finitefix branch November 22, 2017 14:22
@anriseth anriseth mentioned this pull request Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants