Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for 1.0, follow CI scripts from NLSolversBase #129

Merged
merged 7 commits into from
Sep 12, 2018
Merged

Conversation

anriseth
Copy link
Collaborator

No description provided.

@pkofod
Copy link
Member

pkofod commented Sep 12, 2018

Seems to be a problem with higherprecision?

@anriseth
Copy link
Collaborator Author

Yes, it has been deprecated in favour of DoubleFloats.jl, but that opened another can of worms. JuliaMath/DoubleFloats.jl#18 (default values set to Inf became NaN with DoubleFloats)

@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #129 into master will increase coverage by 3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
+ Coverage   66.83%   69.84%   +3%     
=======================================
  Files           8        8           
  Lines         392      388    -4     
=======================================
+ Hits          262      271    +9     
+ Misses        130      117   -13
Impacted Files Coverage Δ
src/backtracking.jl 85.18% <0%> (-1.03%) ⬇️
src/morethuente.jl 59.3% <0%> (+0.68%) ⬆️
src/initialguess.jl 89.47% <0%> (+2.46%) ⬆️
src/hagerzhang.jl 56.61% <0%> (+7.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 066280d...ecf36a2. Read the comment docs.

@anriseth anriseth merged commit 2387769 into master Sep 12, 2018
@anriseth anriseth deleted the enableoptim branch September 12, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants