Remove special polynomial methods #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates for Julia 0.6
``secant()`` previously chose a guess of ``NaN`` if the function took on infinite values. It now chooses ``(a+b)/2``. This problem did not arise on the code path for ``Float64`` calculations, so it remained hidden.
Update CI URLs to point to new caching infrastructure
|
Given issue JuliaLang/julia#21969 it seems more like this is a good idea. This PR moves out the polynomial specific code into another package making the dependencies of Roots much fewer. |
|
The commits are kind of weird here. You might need to rebase from master. |
Merged
|
Closing this, as rebase got messed up. See #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the polynomial specific code from
Roots. That code will find its way intohttps://github.com/jverzani/PolynomialZeros.jl. It always seemed not quite right to have the two things in this package as they didn't have much in common. In addition to that separation, the PR bumps the required Julia version, avoiding Compat usage and fixes an ambiguity that arose with new work in v0.6.