Consolidate Base combinatorics features #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DROP 0.4 SUPPORT - Import most of base/combinatorics.jl (Ref: JuliaLang/julia#13897) - Move most of the special numbers to numbers.jl - Put combinations, permutations and partitions in their own files - Rename special numbers with ~num suffix. This renaming is particularly important for catalannum to avoid clashing with the Base.catalan irrational constant.
Functions from src/foo.jl are now tested in test/foo.jl
Also: - clean up readme - expose docs that were buried in comments - get rid of @compat usage
| #end | ||
|
|
||
| """ | ||
| Previous integer not greater than `n` that can be written as $\prod k_i^{p_i}$ for integers $p_1$, $p_2$, etc. |
There was a problem hiding this comment.
You need to use doc"..." to be able to write latex like this. That's the current travis failure.
There was a problem hiding this comment.
Thanks; forgot to fix that
jiahao
added a commit
that referenced
this pull request
Nov 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts all combinatorics functions from Julia's
Baselibrary, except forbinomial,factorial, andgamma.There is also a major reorg of functions and their tests.
Cross-reference: JuliaLang/julia#5155 JuliaLang/julia#13897