Consistent varargs specialization in stagedfunctions (fix #8944) #8960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passes JuMP's tests. |
|
That's great to know, many thanks! I think I'll just go ahead and merge. |
|
...after adding a test (should have done that at the beginning). |
These are about to become part of fairly low-level infrastructure, so it's best to run them early.
timholy
force-pushed
the
teh/staged_cache
branch
from
f5b3b0f to
cc7427f
Compare
timholy
added a commit
that referenced
this pull request
Nov 11, 2014
Consistent varargs specialization in stagedfunctions (fix #8944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically an alternative version of @mlubin's fix. Anyone who is using stagedfunctions in their own code may want to test, but for me this appears likely to finally clear the path to merging the SubArray work. I'll wait until the Travis test clears, of course. (Sadly,
make testallnow force-reboots my laptop about 10% of the time, presumably due to memory-exhaustion, so I run it less and less. Thank goodness for Travis.)While I would appreciate a code-review from Dr. Bezanson, Mr. Bezanson need not bother. Dr. Bezanson can clean up any messes I make, later.