-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise @simd
documentation.
#8704
Conversation
0485249
to
a3a0d6c
Compare
Seems like this is correct for 0.3 users also? (apart from the compile-time error) |
Yes, it would be good to backport it. I'd be happy to submit a pull request for that if someone will explain how to do so (I should learn this stuff). The compile-time error sentence should be changed to something such as:
|
Submitting a backport PR is pretty simple. First, you'll want to create a new branch based off of Probably the easiest way to do this, is to try and cherry-pick the commit here onto a new branch that is based off of
This will attempt to apply the diff represented by a3a0d6c onto the current state of the |
I'd also recommend to keep a separate directory for For documentation backports, you can also push them directly into the repository and just link the commit here, instead of creating a branch and a PR.
|
…esults. (cherry picked and edited from commit a3a0d6c) ref: JuliaLang#8704
Thanks for the pointers. I ended up creating a pull request and merging it, because I wanted to go through the steps of merging a PR (and I figured practicing on documentation was safer than code.) |
Three changes:
@simd
loops with break / continue /@goto
in inner loop body #8624).&&
,||
, and?:
sometimes vectorize and use ofifelse
instead of?:
..rst
source to avoid excessively long lines and have consistent indentation.