Make accept() throw more useful errors #7822
Conversation
| @@ -862,7 +862,7 @@ function accept(server::UVServer, client::AsyncStream) | |||
| end | |||
| stream_wait(server,server.connectnotify) | |||
| end | |||
| error("server was closed while attempting to accept a client") | |||
| uv_error("accept", UV_ECONNABORTED) | |||
There was a problem hiding this comment.
This calls into question what uv_error really means. After all, this error is not returned by libuv. I also generally dislike classifying errors according to which library threw them, but that's not specific to this PR of course.
There was a problem hiding this comment.
The only reason libuv isn't returning this error is because we explicitly check on the julia side for the condition that would cause libuv to return this error. If we didn't have that isopen(server) check, this is the error that would be raised by libuv.
I guess we could just map this to a SystemError instead, which I would have done, except that I wanted to be consistent with the rest of our socket/IO code. I guess we could just create an IOError type that holds the UV_* codes instead (which are really just errno codes anyway).
Make accept() throw more useful errors
|
Amazing how the seemingly smallest of changes always provoke the most intense of discussions. |
No description provided.