Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the nice LineEditREPL on Windows #6560

Merged
merged 1 commit into from
Apr 18, 2014
Merged

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Apr 17, 2014

Windows doesn't have the TERM env var set outside of MSYS/Cygwin, so c8ae026 caused Windows Julia to default to the BasicREPL.

The LineEditREPL still has line duplication bugs on Windows (#6488), but overall it's a nicer experience than the BasicREPL.

This may un-fix #6428 on Windows, but I suspect Windows users are more frequently running Julia from cmd or by double-clicking than inside Emacs.

Windows doesn't have the TERM env var set outside of MSYS/Cygwin,
so c8ae026 caused Windows Julia to default to the BasicREPL.
@ihnorton
Copy link
Member

+1. @nolta?

(travis failure looks unrelated)

nolta added a commit that referenced this pull request Apr 18, 2014
Bring back the nice LineEditREPL on Windows
@nolta nolta merged commit ca44f9b into JuliaLang:master Apr 18, 2014
@tkelman tkelman deleted the patch-5 branch April 18, 2014 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPL: running inside emacs crashes (shell, eshell) or prompt is double-printed (term)
3 participants