[backports-release-1.10] allow extensions to trigger from packages in [deps] (#54009) #56383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
KristofferC
requested changes
Oct 30, 2024
KristofferC
force-pushed
the
backports-release-1.10
branch
from
9110615 to
27a0143
Compare
topolarity
force-pushed
the
ct/backport-54009
branch
2 times, most recently
from
41c5519 to
7710e7b
Compare
KristofferC
reviewed
Oct 30, 2024
KristofferC
reviewed
Oct 30, 2024
topolarity
force-pushed
the
ct/backport-54009
branch
from
7710e7b to
a18f75e
Compare
KristofferC
approved these changes
Oct 30, 2024
|
Tests are failing due to #56264 (comment) |
… [deps] (JuliaLang#54009) There is a use case where you have a weak dependency (for one of your extensions) that is misbehaving and you quickly want to try debug that issue. A workflow that feels reasonable for this could be: ``` pkg> dev WeakDependency julia> using Package, WeakDependency ``` This doesn't work right now for two reasons: 1. Doing the `dev WeakDependency` will add the dependency to `[deps]` but not remove it from `[weakdeps]` which means you all of a sudden are in the scenario described in https://pkgdocs.julialang.org/v1/creating-packages/#Transition-from-normal-dependency-to-extension which is not what is desired. 2. The extension will not actually load because you can right now only trigger extensions from weak deps getting loaded, not from deps getting loaded. Point 1. is fixed by JuliaLang/Pkg.jl#3865 Point 2. is fixed by this PR. (cherry picked from commit f46cb4c)
topolarity
force-pushed
the
ct/backport-54009
branch
from
a18f75e to
385caed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #54009