Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtype: bug fix for bounds with deeper covariant var #50832

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Aug 8, 2023

fix #50716.

@N5N3 N5N3 added types and dispatch Types, subtyping and method dispatch bugfix This change fixes an existing bug labels Aug 8, 2023
@N5N3
Copy link
Member Author

N5N3 commented Aug 8, 2023

@nanosoldier runtests()

@oscardssmith
Copy link
Member

should we run a pkgeval on this?

@N5N3 N5N3 marked this pull request as draft August 8, 2023 13:21
@N5N3

This comment was marked as outdated.

Some tests depend on the bug fixed.
For example, the `convert` test for `NamedTuple` works because `Tuple{Type{NamedTuple{(:a,),Tuple{I}} where I<:Unsigned}} <: Tuple{Type{NT}} where {names, T<:Tuple, NT<:NamedTuple{names,T}}` on master.
@N5N3 N5N3 marked this pull request as ready for review August 8, 2023 14:49
@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

This branch is unreachable at runtime unless `NT` has free typevar.
@N5N3 N5N3 merged commit ebae716 into JuliaLang:master Aug 10, 2023
@N5N3 N5N3 deleted the subfix branch August 10, 2023 00:23
@giordano giordano added the backport 1.10 Change should be backported to the 1.10 release label Oct 27, 2024
KristofferC pushed a commit that referenced this pull request Oct 29, 2024
@KristofferC KristofferC mentioned this pull request Oct 29, 2024
47 tasks
KristofferC added a commit that referenced this pull request Nov 12, 2024
Backported PRs:
- [x] #50832 <!-- Subtype: bug fix for bounds with deeper covariant var
-->
- [x] #51782 <!-- Fix remove-addrspaces pass in the presence of globals
with addrspaces -->
- [x] #55720 <!-- Fix `pkgdir` for extensions -->
- [x] #55773 <!-- Add compat entry for `Base.donotdelete` -->
- [x] #55886 <!-- irrationals: restrict assume effects annotations to
known types -->
- [x] #55867 <!-- update `hash` doc string: `widen` not required any
more -->
- [x] #56148 <!-- Make loading work when stdlib deps are missing in the
manifest -->
- [x] #55870 <!-- fix infinite recursion in `promote_type` for
`Irrational` -->
- [x] #56252 <!-- REPL: fix brace detection when ' is used for transpose
-->
- [x] #56264 <!-- inference: fix inference error from constructing
invalid `TypeVar` -->
- [x] #56276 <!-- move time_imports and trace_* macros to Base but
remain owned by InteractiveUtils -->
- [x] #56254 <!-- REPL: don't complete str and cmd macros when the input
matches the internal name like `r_` to `r"` -->
- [x] #56280 <!-- Fix trampoline warning on x86 as well -->
- [x] #56304 <!-- typeintersect: more fastpath to skip intersect under
circular env -->
- [x] #56306 <!-- InteractiveUtils.jl: fixes issue where subtypes
resolves bindings and causes deprecation warnings -->
- [x] #42080 <!-- recommend explicit `using Foo: Foo, ...` in package
code (was: "using considered harmful") -->
- [x] #56441 <!-- Profile: mention `kill -s SIGUSR1 julia_pid` for Linux
-->
- [x] #56511 <!-- The `info` in LAPACK calls should be a Ref instead of
a Ptr -->
- [x] #55052 <!-- Fix `(l/r)mul!` with `Diagonal`/`Bidiagonal` -->
- [x] #52694 <!-- Reinstate similar for AbstractQ for backward
compatibility -->
@KristofferC KristofferC mentioned this pull request Nov 22, 2024
30 tasks
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug types and dispatch Types, subtyping and method dispatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect subtyping result for Ref{Vector{Tuple{K}} where K} <: Ref{<:Vector{K}} where K
6 participants