Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add text/html writemime for MethodList and Method (fix #4952) #4991

Merged
merged 2 commits into from
Dec 23, 2013

Conversation

stevengj
Copy link
Member

The main point of this, besides a bit of pretty-printing, is to automatically link to github for Julia and Pkg source code (#4952).

Sample output:
methodshow

@JeffBezanson
Copy link
Member

Slick!

@jiahao
Copy link
Member

jiahao commented Dec 1, 2013

cc: @alanedelman

@ViralBShah
Copy link
Member

Is this ready to be merged?

@stevengj
Copy link
Member Author

stevengj commented Dec 4, 2013

Yes?

@stevengj
Copy link
Member Author

stevengj commented Dec 7, 2013

@StefanKarpinski, it would be good to get your feedback on this regarding url(::Method).

@jiahao
Copy link
Member

jiahao commented Dec 15, 2013

bump

@malmaud
Copy link
Contributor

malmaud commented Dec 22, 2013

This is incredibly useful

@stevengj
Copy link
Member Author

rebased for merge

@StefanKarpinski
Copy link
Member

So what feedback did you want from me?

@stevengj
Copy link
Member Author

@StefanKarpinski, basically whether there is something I should be doing differently to get the URL of a method in a package.

@StefanKarpinski
Copy link
Member

I man, I dunno. This looks pretty comprehensive. I suspect that we'll have to muddle our way through this one and figure out what's good and what's annoying as people use it. Please don't let me hold this up.

stevengj added a commit that referenced this pull request Dec 23, 2013
add text/html writemime for MethodList and Method (fix #4952)
@stevengj stevengj merged commit d135a07 into JuliaLang:master Dec 23, 2013
@stevengj
Copy link
Member Author

Okay, merged. We can incorporate other improvements as needed (e.g. @ivarne's suggestion to use Base.BUILD_INFO.fork_master_distance to infer whether one is using a Julia commit that has been pushed to github.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants