run JuliaFormatter on Base64 stdlib #47151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Moelf
commented
Oct 13, 2022
| @@ -69,10 +69,10 @@ function Base.unsafe_write(pipe::Base64EncodePipe, ptr::Ptr{UInt8}, n::UInt)::In | |||
| i = 0 | |||
| p_end = ptr + n | |||
| while true | |||
| buffer[i+1] = encode(b1 >> 2 ) | |||
There was a problem hiding this comment.
these are examples of unwanted alignment change
this can also happen at location of = instead of ()
Moelf
changed the title
|
It seems that the Formatter here is making some things worse, which were hand formatted for readability. |
|
indeed. we're waiting for upstream to make more things "opt in": domluna/JuliaFormatter.jl#561 |
|
Close this for now and reopen when upstream addresses the formatting issues? |
|
why not leave it open? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of:
this is one of the smallest stdlib with some interesting patterns. We can use this to test/suggest
features (mostly, how to opt-out of certain formatting) to JuliaFormatter
cc. @domluna