Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

follow up #44786, fix findsup to return correct overlayed value #44804

Merged
merged 1 commit into from
Apr 1, 2022
Merged

follow up #44786, fix findsup to return correct overlayed value #44804

merged 1 commit into from
Apr 1, 2022

Conversation

aviatesk
Copy link
Member

We may want to merge #44785 soonish so that we can explicitly test this kind of effect system related functionalities:

global x44786 = 42
invoke44786() = Base.@invoke sin(x44786::Float64)
@test Base.infer_effects(invoke44786) |> Core.Compiler.is_nonoverlayed

@aviatesk aviatesk added embarrassing-bugfix Whoops! backport 1.8 Change should be backported to release-1.8 labels Mar 31, 2022
@aviatesk aviatesk merged commit 3888176 into master Apr 1, 2022
@aviatesk aviatesk deleted the avi/44786 branch April 1, 2022 01:01
aviatesk added a commit that referenced this pull request Apr 1, 2022
@aviatesk
follow up #44786, fix findsup to return correct overlayed value (#…
1693503 
…44804)
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
67 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
embarrassing-bugfix Whoops!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aviatesk @KristofferC