Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.6: Backports for 1.6.5 #43152

Merged
merged 13 commits into from
Dec 11, 2021
Merged

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Nov 19, 2021

Backported PRs:

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:

@KristofferC KristofferC added the release Release management and versioning. label Nov 19, 2021
aviatesk and others added 12 commits November 26, 2021 13:04
In order to allow `Argument`s to be printed nicely.

> before
```julia
julia> code_typed((Float64,)) do x
           sin(x)
       end
1-element Vector{Any}:
 CodeInfo(
1 ─ %1 = invoke Main.sin(_2::Float64)::Float64
└──      return %1
) => Float64

julia> code_typed((Bool,Any,Any)) do c, x, y
           z = c ? x : y
           z
       end
1-element Vector{Any}:
 CodeInfo(
1 ─      goto #3 if not c
2 ─      goto #4
3 ─      nothing::Nothing
4 ┄ %4 = φ (#2 => _3, #3 => _4)::Any
└──      return %4
) => Any
```

> after
```julia
julia> code_typed((Float64,)) do x
           sin(x)
       end
1-element Vector{Any}:
 CodeInfo(
1 ─ %1 = invoke Main.sin(x::Float64)::Float64
└──      return %1
) => Float64

julia> code_typed((Bool,Any,Any)) do c, x, y
           z = c ? x : y
           z
       end
1-element Vector{Any}:
 CodeInfo(
1 ─      goto #3 if not c
2 ─      goto #4
3 ─      nothing::Nothing
4 ┄ %4 = φ (#2 => x, #3 => y)::Any
└──      return %4
) => Any
```
The added condition improves compatiblity with Nix mtime.

(cherry picked from commit f5e0f9d)
This version has been rebuilt to have 32 threads by default, instead of 512 as
it accidentally happened before.  The large number of threads caused problems on
some platforms, including `StackOverflowError`s.
Includes several fixes: JuliaLang/libuv@c6869fb...3a63bf7

(cherry picked from commit 2b1ece9)
If connect(::CustomClusterManager, ...) returns a custom transport
stream, use of that stream by the task in start_gc_msgs_task() may fail
due to the task executing in an old world age. Add an invokelatest() to
prevent this problem.

(cherry picked from commit a05bcb2)
I am not sure why we ever used round+1 instead of ceil+1, as this is
simply strictly more correct.

(cherry picked from commit d6f59fa)
Just explicitely check for `CodeInfo` objects and use an explicit
`return` in this case inside the `@generated` macro.

Co-authored-by: Jeff Bezanson <[email protected]>
(cherry picked from commit 92c84bf)
@KristofferC KristofferC reopened this Dec 10, 2021
@KristofferC
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":release-1.6")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@KristofferC
Copy link
Member Author

@nanosoldier runtests(["AlgebraOfGraphics", "BLASBenchmarksCPU", "Biplots", "ChaosTools", "CommunityDetection", "Convex1d", "GADM", "Gemini", "GeoMakie", "InteractiveDynamics", "JUDI", "JUDI4Cloud", "KissMCMC", "LightGraphs", "MaxwellFDFD", "MusicManipulations", "NEOSServer", "ReliabilityDiagrams", "Relief", "Syslogs", "TexasHoldem", "VoronoiGraph", "ZigZagBoomerang"], vs = ":release-1.6")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@KristofferC KristofferC merged commit 5d28959 into release-1.6 Dec 11, 2021
@KristofferC KristofferC deleted the backports-release-1.6 branch December 11, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.