Code

Allocation profiler#42768

Code

Merged

NHDaly merged 112 commits intoJuliaLang:masterJuliaLang/julia:masterfrom vilterp:pv-alloc-profile-flat-stacksvilterp/julia:pv-alloc-profile-flat-stacksCopy head branch name to clipboardJan 19, 2022

+620-2

Commits

Commits on Jan 7, 2022

• alloc profiler

  vilterp

  committed
  b49dd24

• fix key

  vilterp

  committed
  2fe1678

• don't skip stdlib

  vilterp

  committed
  c370f5a

• rename

  vilterp

  committed
  b8cffd3

• record freed values

  vilterp

  committed
  c733cd6

• print frees by type

  Show description for 964a8a4
  vilterp

  committed
  964a8a4

• fix recording & printing of frees

  vilterp

  committed
  aed5f5d

• Return the raw data from the C++ allocations vector into julia!! :)

  

  NHDaly

  authored and

  vilterp

  committed
  665cacd

• get started on decoding on Julia side

  vilterp

  committed
  7ed832e

• delete more serialization code

  vilterp

  committed
  371bb96

• delete destructors and constructors

  Show description for c8452ce
  vilterp

  committed
  c8452ce

• use unique_ptr

  Show description for 2d9ec5b
  vilterp

  committed
  2d9ec5b

• separate free function; move Julia decoding to stdlib

  vilterp

  committed
  5cd096a

• move more to the stdlib

  vilterp

  committed
  04e2b17

• start hacking on _reformat_bt

  Show description for 77ce036
  vilterp

  committed
  77ce036

• fix decoding

  vilterp

  committed
  33dde11

• get alloc size and type address

  Show description for 07d1009
  vilterp

  committed
  07d1009

• just keep type type address for now

  vilterp

  committed
  6ec2fd0

• send type names over to the Julia side

  Show description for f5f1be2
  vilterp

  committed
  f5f1be2

• package up frees as well

  vilterp

  committed
  9fe1ad2

• try to fix

  Show description for f768234
  vilterp

  committed
  f768234

• malloc strings so they're not junk by the time we look at them

  Show description for b11a0fe
  vilterp

  committed
  b11a0fe

• implement caching of stack trace lookups

  Show description for c1faa44
  vilterp

  committed
  c1faa44

• add GC.@preserve, magically fixing segfaults (???)

  Show description for 671b88e
  vilterp

  committed
  671b88e

• delete code to stringify type names on C++ side

  Show description for 6932831
  vilterp

  committed
  6932831

• Fix hang in GC: use jl_safe_printf not jl_printf

  

  NHDaly

  authored and

  vilterp

  committed
  e164cc8

• Mark the AllocProfile C code as JL_NOTSAFEPOINT

  Show description for c736dbc
  

  NHDaly

  authored and

  vilterp

  committed
  c736dbc

• print incr. vs full

  vilterp

  committed
  9407a91

• put test back in; get it passing

  vilterp

  committed
  f297d94

• simpler Base.show for AllocResults

  vilterp

  committed
  50dcb63

• remove gc.preserve

  vilterp

  committed
  976d2bc

• add top level profile function

  vilterp

  committed
  e1b2221

• clear after decoding

  vilterp

  committed
  03a0102

• free memory allocated for results

  vilterp

  committed
  7975c77

• first hack at multithreaded profiler

  vilterp

  committed
  2c84bb9

• tweaks

  vilterp

  committed
  b49606d

• hold onto vectors

  Show description for 84745bf
  vilterp

  committed
  84745bf

• fix some compile errors

  vilterp

  committed
  a03cfe3

• Remove file println debugging

  

  NHDaly

  authored and

  vilterp

  committed
  79427ca

• Add precompile statements to AllocProfile package

  Show description for 9f63529
  

  NHDaly

  authored and

  vilterp

  committed
  9f63529

• add comment about precompilation

  

  NHDaly

  authored and

  vilterp

  committed
  7d12971

• Malloc right-sized buffers for backtraces.

  Show description for a26f375
  

  NHDaly

  authored and

  vilterp

  committed
  a26f375

• test that we get a free

  vilterp

  committed
  b5ab611

• remove GC logging. splitting off into another PR

  vilterp

  committed
  d53afa2

• remove a couple debugging things

  vilterp

  committed
  9de01c6

• add macro interface; use in test

  vilterp

  committed
  cdabd0e

• fix whitespace

  vilterp

  committed
  ba3c0c8

• make skip_every a named optional argument to the macro

  vilterp

  committed
  ddf945c

• remove debug logs

  Show description for e2a8ba3
  vilterp

  committed
  e2a8ba3

• add multithreaded test

  vilterp

  committed
  ad1b0e0

• skip another frame to avoid record_allocated_value

  vilterp

  committed
  a712267

• move AllocProfile into Profile package

  vilterp

  committed
  ec6cc6f

• rename AllocProfile => Profile.Allocs

  vilterp

  committed
  83ef9ea

• load types: stop using threshold hack; just check for jl_buff_tag

  vilterp

  committed
  44073ef

• remove unused struct

  vilterp

  committed
  b3e5102

• remove unused profile function

  Show description for 0fd988b
  vilterp

  committed
  0fd988b

• first hack at fetch API

  vilterp

  committed
  0119ce3

• switch to uniform sampling with rand()

  Show description for 9d06356
  vilterp

  committed
  9d06356

• small default sample rate

  Show description for f0d7da4
  

  vilterp

  and

  NHDaly

  committed
  f0d7da4

• update comment

  vilterp

  committed
  cecf3a1

• Comments + formatting cleanup for C files

  

  NHDaly

  authored and

  vilterp

  committed
  545d06c

• Cleanups & comments & docstring

  

  NHDaly

  authored and

  vilterp

  committed
  e1f8684

• Split out and update Profile.Allocs tests

  

  NHDaly

  authored and

  vilterp

  committed
  7de1d5f

• Move the extern "C" around the impl of external funcs for Allocs

  Show description for 7c862da
  

  NHDaly

  authored and

  vilterp

  committed
  7c862da

• remove pritnln

  

  NHDaly

  authored and

  vilterp

  committed
  2c271ab

• move structs to header

  

  NHDaly

  authored and

  vilterp

  committed
  2cb0a59

• Tried to fix compile error still failed...

  

  NHDaly

  authored and

  vilterp

  committed
  535c2fc

• Revert move struct defs - use forward decl instead

  

  NHDaly

  authored and

  vilterp

  committed
  af8931c

• Rename BTElementT and add docstring example

  

  NHDaly

  authored and

  vilterp

  committed
  f47253c

• remove garbage profile stuff

  Show description for 423830d
  vilterp

  committed
  423830d

• remove unordered_map

  vilterp

  committed
  4a86866

• Fix typo after merge

  

  NHDaly

  authored and

  vilterp

  committed
  d02a5b6

• Finish comment

  

  NHDaly

  authored and

  vilterp

  committed
  bfd6210

• fix typo

  

  NHDaly

  authored and

  vilterp

  committed
  ff00317

• Stop clearing the profiled Allocations on start()

  

  NHDaly

  authored and

  vilterp

  committed
  e07e67d

• Fix tests after remove Garbage Profiler (frees)

  

  NHDaly

  authored and

  vilterp

  committed
  ed4cb44

• rename to to maybe_record_alloc_to_profile

  vilterp

  committed
  c27971b

• small test cleanups

  vilterp

  committed
  48261b5

• Fix double-free in the stop,fetch,clear logic

  

  NHDaly

  authored and

  vilterp

  committed
  43276f4

• Add test for start stop fetch clear

  

  NHDaly

  authored and

  vilterp

  committed
  8062b72

• Ah, fix tricky C++ism: missing a & caused accidental double-free

  

  NHDaly

  authored and

  vilterp

  committed
  aeec3b6

• print warning message

  vilterp

  committed
  00bb947

• Update stdlib/Profile/src/Allocs.jl

  Show description for d3d868f
  

  NHDaly

  authored and

  vilterp

  committed
  d3d868f

• a couple cleanups; remove multithread assertion

  vilterp

  committed
  d352a80

• remove unordered_map import

  vilterp

  committed
  3aaa9d9

• first crack at docs

  vilterp

  committed
  db64f63

• add news

  vilterp

  committed
  5c25bcd

• Apply suggestions from code review

  Show description for 4fec8dd
  NHDaly

  authored
  4fec8dd

• PR feedback

  vilterp

  committed
  9a4b7fb

• Merge branch 'pv-alloc-profile-docs-feedback' into pv-alloc-profile-docs

  vilterp

  committed
  5dc2beb

• Merge pull request #13 from vilterp/pv-alloc-profile-docs

  Show description for 830e2ad
  vilterp

  authored
  830e2ad

Commits on Jan 11, 2022

• rename structs to match Julia style

  vilterp

  committed
  cd14357

• Merge pull request #16 from vilterp/pv-alloc-profile-style-renames

  Show description for 0f39d48
  vilterp

  authored
  0f39d48

• print out percentage of allocs missed

  vilterp

  committed
  e98589b

• remove some debug printlns

  vilterp

  committed
  107ece0

• PR feedback

  Show description for c4bebea
  vilterp

  committed
  c4bebea

• more PR feedback: _ before global names

  vilterp

  committed
  f4f1a62

• rename jl_raw_alloc_results_t => jl_profile_allocs_raw_results_t

  vilterp

  committed
  452c7cd

• remove @shows

  vilterp

  committed
  3f219c7

• Merge pull request #15 from vilterp/pv-alloc-profile-allocs-missed

  Show description for b25005a
  vilterp

  authored
  b25005a

Commits on Jan 12, 2022

• record string allocs

  vilterp

  committed
  bf08801

• add string test

  vilterp

  committed
  8ec194b

• Merge pull request #18 from vilterp/pv-alloc-profile-record-strings

  Show description for 41f169c
  vilterp

  authored
  41f169c

• alloc profiler: avoid divide-by-zero errors (#19)

  Show description for 3fc80ac
  vilterp

  authored
  3fc80ac

Commits on Jan 13, 2022

• add paragraph about missed allocations

  Show description for 9465507
  

  vilterp

  and

  NHDaly

  authored
  9465507

Commits on Jan 18, 2022

• use !!! note style in comment

  vilterp

  committed
  76ad6f0

• only print warning when missed_percentage > 0

  vilterp

  committed
  dd693cc

• Attempt to test the warning logs, but struggling to capture stderr

  Show description for 4deaf6c
  NHDaly

  committed
  4deaf6c

• Remove the tests, but at least exercise both cases...

  NHDaly

  committed
  13a85de

• improve warning wording to indicate sampling

  NHDaly

  committed
  68e1a15

• Add type assertion for alloc profiler unit tests

  NHDaly

  committed
  b5f636a

Commits on Jan 19, 2022

• remove superfluous whitespace

  vilterp

  committed
  b16b610